-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More customization options, bug fixes, and future compatibility. #69
Open
shadow-of-arman
wants to merge
20
commits into
jeantimex:master
Choose a base branch
from
shadow-of-arman:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadow-of-arman
commented
Jan 26, 2021
- Changed the arrowLabel to arrowImageView, so it can be changed by whom ever is using this framework. added a default arrow for the framework that is less pointy than >.
- Added a color value for the arrow so devs can change the color of the arrow easier, no matter what icon they are using.
- Added a section background color value so devs can change the background color of the collapsable section.
- Added an alignment value that changes the alignment of the section label AND changes the position of the arrow depending on left or right, so this framework can support languages like Persian or Arabic since they are right to left aligned.
- Changed how the animation for the arrow rotating was written, (used CGAffineTransform) which resulted in a smoother animation and removed the bug that displayed no animation when rotating back up. (collapsed)
- Removed a bug that would reset the arrow to collapsed mode even though the section was still open. (this occurred when an open section would get redrawn when going outside the visible view)
- Resolved every single warning that happened when setting the minimum deployment target above iOS 11, removed deprecated code if iOS version meets the requirement, and changed the swift version to swift 5.
- Updated travis.yml to test on newer iOS versions on a newer Xcode version.
…eployment target to 11.
…he bug that set the incorrect arrow rotation when tableview reloads.
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=========================================
Coverage ? 86.98%
=========================================
Files ? 2
Lines ? 146
Branches ? 0
=========================================
Hits ? 127
Misses ? 19
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.