Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More customization options, bug fixes, and future compatibility. #69

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

shadow-of-arman
Copy link

  1. Changed the arrowLabel to arrowImageView, so it can be changed by whom ever is using this framework. added a default arrow for the framework that is less pointy than >.
  2. Added a color value for the arrow so devs can change the color of the arrow easier, no matter what icon they are using.
  3. Added a section background color value so devs can change the background color of the collapsable section.
  4. Added an alignment value that changes the alignment of the section label AND changes the position of the arrow depending on left or right, so this framework can support languages like Persian or Arabic since they are right to left aligned.
  5. Changed how the animation for the arrow rotating was written, (used CGAffineTransform) which resulted in a smoother animation and removed the bug that displayed no animation when rotating back up. (collapsed)
  6. Removed a bug that would reset the arrow to collapsed mode even though the section was still open. (this occurred when an open section would get redrawn when going outside the visible view)
  7. Resolved every single warning that happened when setting the minimum deployment target above iOS 11, removed deprecated code if iOS version meets the requirement, and changed the swift version to swift 5.
  8. Updated travis.yml to test on newer iOS versions on a newer Xcode version.

@codecov-io
Copy link

codecov-io commented Jan 26, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@86645bc). Click here to learn what that means.
The diff coverage is 79.16%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #69   +/-   ##
=========================================
  Coverage          ?   86.98%           
=========================================
  Files             ?        2           
  Lines             ?      146           
  Branches          ?        0           
=========================================
  Hits              ?      127           
  Misses            ?       19           
  Partials          ?        0           
Impacted Files Coverage Δ
...roller/CollapsibleTableSectionViewController.swift 91.02% <76.47%> (ø)
...ionViewController/CollapsibleTableViewHeader.swift 82.35% <80.64%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86645bc...25f3b64. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants