Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version parsing and Git sparse-clone check #151

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Fix version parsing and Git sparse-clone check #151

merged 4 commits into from
Jun 24, 2024

Conversation

jdoiro3
Copy link
Owner

@jdoiro3 jdoiro3 commented Jun 24, 2024 •
edited
Loading

  • No idea why I thought I needed to do padding when parsing the version. What a silly thing to do.
  • sparse-clone was added in 2.25 but the comparison was inverted.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 24, 2024 •
edited
Loading

Version Number Check

Version has been updated in pyproject.toml.

@jdoiro3 jdoiro3 mentioned this pull request Jun 24, 2024
Closed
@jdoiro3 jdoiro3 changed the title Fix version parsing Fix version parsing and Git sparse-clone check Jun 24, 2024
@jdoiro3 jdoiro3 mentioned this pull request Jun 24, 2024
Closed
@jdoiro3 jdoiro3 merged commit f017969 into main Jun 24, 2024
14 checks passed
@jdoiro3 jdoiro3 deleted the fix/version-parsing branch June 24, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jdoiro3