-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecation warning #131
Conversation
According to the logs this function is deprecated and also filtering of files can have an impact to some projects. By default it's not possible to add dot directories, dot files or the folder templates to the documentation. INFO - DeprecationWarning: warning_filter doesn't do anything since MkDocs 1.2 and will be removed soon. All messages on the `mkdocs` logger get counted automatically. File "xxx/.venv/lib/python3.9/site-packages/mkdocs_multirepo_plugin/util.py", line 10, in <module> from mkdocs.utils import warning_filter File "xxx/.venv/lib/python3.9/site-packages/mkdocs/utils/__init__.py", line 453, in __getattr__ warnings.warn(
According to the logs this function is deprecated (a NOP).
Version Number CheckVersion has been updated in pyproject.toml. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First off, thanks for contributing and using the plugin. I left a few suggestions/comments for you to address. I'm trying to get better at the version bumps and suggest we change the version to 0.7.0
since the other change part of this release isn't just a bugfix and changes behavior. Let me know if you don't agree.
Co-authored-by: Joseph Doiron <[email protected]>
Co-authored-by: Joseph Doiron <[email protected]>
Co-authored-by: Joseph Doiron <[email protected]>
Co-authored-by: Joseph Doiron <[email protected]>
Remove the deprecation warnings:
Removing the function
_filter_paths
will also add support to include files in dot folders, dot files and the template folder.To generate the documentation in ADO project we need to reference the pipeline in the folder
.azuredevops
and if you're documentinghelm
charts you have a foldertemplates
.