fix: find osgi loader #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozhelezniak-talend
force-pushed
the
ozhelezniak/fix_osgi_loader_issue
branch
from
4ea6f26 to
55a5cde
Compare
ozhelezniak-talend
force-pushed
the
ozhelezniak/fix_osgi_loader_issue
branch
from
55a5cde to
2ae9520
Compare
|
Hello @jdereg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous implementation didn't take into account the method BundleImpl.adapt is inside package-private package and it can't be accessible from ClassUtils.class
Also, java-util bundle ClassLoader has access to only its resources.
Example:
In the case of json-io we want to find the resources in that jar that's why we need to look in its bundle classloader instead.
Related PRs:
jdereg/json-io#298
#108