fixed insidious little bug. "" compared with == instead of .equals().…

… Was working because "" was usually within the LRUCache, unless it's size was set small enough.
jdereg · Dec 11, 2023 · 871e411 · 871e411
1 parent 4718547
commit 871e411
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/test/java/com/cedarsoftware/util/TestCompactMap.java b/src/test/java/com/cedarsoftware/util/TestCompactMap.java
@@ -75,7 +75,7 @@ protected Map<String, Object> getNewMap()
         assert map.size() == 2;
         assert !map.isEmpty();
 
-        assert map.remove("alpha") == "beta";
+        assert map.remove("alpha").equals("beta");
         assert map.size() == 1;
         assert !map.isEmpty();
 

diff --git a/src/test/java/com/cedarsoftware/util/TestConverter.java b/src/test/java/com/cedarsoftware/util/TestConverter.java
@@ -1480,7 +1480,7 @@ public void testNullInstance()
         assert false == convert2AtomicBoolean(null).get();
         assert 0 == convert2AtomicInteger(null).get();
         assert 0L == convert2AtomicLong(null).get();
-        assert "" == convert2String(null);
+        assert "".equals(convert2String(null));
     }
 
     @Test