Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trajectory.py #3

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

directysj
Copy link

I have added a subclass to the Trajectory class, please have a look .

@jcopperm
Copy link
Owner

jcopperm commented Mar 6, 2023

Jalim, I don't think merging these branches makes sense. It looks like you have altered the main trajectory class in trajectory.py for your cellpose based analysis. We should bring this up in code review and ask John for some ideas here. Without subclassing, I don't know how to merge these, but without merging I don't see how to keep both branches updated diverging changes.

@directysj
Copy link
Author

directysj commented Mar 6, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants