-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hanging files at instance destroy #74
base: master
Are you sure you want to change the base?
Conversation
@diorcety Thanks for the pull request, let me find a reviewer.. |
@yegor256 pull request is rather short, review it please |
@rultor try to merge |
@diorcety @yegor256 Oops, I failed. You can see the full log here (spent 7min)
|
@rultor try to merge again |
@diorcety @yegor256 Oops, I failed. You can see the full log here (spent 6min)
|
@rultor try to merge now |
@diorcety @yegor256 Oops, I failed. You can see the full log here (spent 40min)
|
@rultor try again, merge |
@diorcety @yegor256 Oops, I failed. You can see the full log here (spent 14min)
|
@diorcety see the log above, there are a few static analysis violations, please fix them |
b4ef9ff
to
e157fdc
Compare
I have updated the commit. I notice lot of print and exception when i stop a instance. There is missing a clean stop of threads and process. Here a modification to have a cleaner exit. Maybe you maybe improve it or, do it in you way. It pollutes a lot the output of my maven process and my ITs |
@diorcety please, try to run |
f823115
to
fa4da6a
Compare
@diorcety can you please take a look at this one? It's a good PR, but has some problems and conflicts. If you fix them, I will try to merge. |
When destroying the instance some file are still open for a while. For example if you try to delete the data directory just after destroy you can have some surprise. I took the example on org.apache.commons.io.FileSystemUtils#performCommand