Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make jcabi-manifests a valid OSGI bundle #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gdelafosse
Copy link

use the maven-bundle-plugin to make jcabi-manifests a valid OSGI bundle

@dmarkov
Copy link

dmarkov commented Jan 7, 2016

@gdelafosse I will find a reviewer for your pull requests shortly, thanks for contribution!

@dmarkov
Copy link

dmarkov commented Jan 7, 2016

@yegor256 review it please, it is a rather short pull request, no need to do a full code review

@gdelafosse
Copy link
Author

Hello
what do you think if I modify the jcabi parent to include the maven-bundle-plugin, so that we just have to change the packaging of any jcabi project to turn it into an OSGI bundle?
It will be less redundant than copying the maven-bundle-plugin configuration to each project...

@yegor256
Copy link
Member

yegor256 commented Jan 7, 2016

@gdelafosse yes, it's a good idea. Actually, the best approach would be to declare this plugin in <pluginManagement> in jcabi/jcabi-parent and then use it in jcabi/jcabi. Then, in each project just change jar packaging to bundle. Make sense?

@gdelafosse gdelafosse mentioned this pull request Jan 7, 2016
@gdelafosse
Copy link
Author

I modified jcabi/jcabi to add the maven-bundle-plugin. See jcabi/jcabi#308.
As mentionned in the comments of this pull request, I wasn't able to use this parent pom into jcabi projects because of some dependencies that have been updated.
Particularly, jcabi-log versus Mockito.

@gdelafosse
Copy link
Author

Any news for this pull request?

@gdelafosse
Copy link
Author

Hello
do you have time to accept it?

@yegor256 yegor256 removed their assignment Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants