-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUD-2083 JDV64 templates #371
base: jdv-wip
Are you sure you want to change the base?
Conversation
"imageChange": { | ||
"from": { | ||
"kind": "ImageStreamTag", | ||
"name": "jboss-datagrid65-client-openshift:1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be using datagrid71 client
datavirt/datavirt64-basic-s2i.json
Outdated
"from": { | ||
"kind": "ImageStreamTag", | ||
"namespace": "${IMAGE_STREAM_NAMESPACE}", | ||
"name": "jboss-datagrid65-client-openshift:1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdecoste You might want to updates this to "jboss-datagrid71-client-openshift:1.0"
datavirt/datavirt64-basic-s2i.json
Outdated
}, | ||
"paths": [ | ||
{ | ||
"destinationDir": "./${CONTEXT_DIR}/extensions/datagrid65", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s#./${CONTEXT_DIR}/extensions/datagrid65"#./${CONTEXT_DIR}/extensions/datagrid71"# ?
datavirt/datavirt64-basic-s2i.json
Outdated
"imageChange": { | ||
"from": { | ||
"kind": "ImageStreamTag", | ||
"name": "jboss-datagrid65-client-openshift:1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/jboss-datagrid65-client-openshift:1.0/jboss-datagrid71-client-openshift:1.0/
"from": { | ||
"kind": "ImageStreamTag", | ||
"namespace": "${IMAGE_STREAM_NAMESPACE}", | ||
"name": "jboss-datagrid65-client-openshift:1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/jboss-datagrid65-client-openshift:1.0/jboss-datagrid71-client-openshift:1.0/
}, | ||
"paths": [ | ||
{ | ||
"destinationDir": "./${CONTEXT_DIR}/extensions/datagrid65", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s#./${CONTEXT_DIR}/extensions/datagrid65#./${CONTEXT_DIR}/extensions/datagrid71# ?
Changes need to be made: "value": "datavirt/dynamicvdb-datafederation/app" needs to be changed to the new datavirt4/.... directory. The new JDV 6.4 quickstart will need to have a new directory, so that JDV 6.3 isn't corrupted. Also, not sure why the ModeShape username/passwords setting were removed. |
This PR is no longer valid, the templates have been moved. |
No description provided.