improve pom #477
improve pom #477
Conversation
- add `inceptionYear` element, and use it in `copyright bottom` - add missing version declaration for `maven-gpg-plugin` more stable build and fix related warning message - add `maven-enforcer-plugin` more straightforward error message when `maven`/`java` version is not satisfied
oldratlee
force-pushed
the
improve-pom
branch
from
6dc9360 to
da2e3dd
Compare
| <version>3.2.5</version> | ||
| </requireMavenVersion> | ||
| <requireJavaVersion> | ||
| <version>11</version> |
There was a problem hiding this comment.
Is this consistent with the other parts? The binary is built by Java 8.
There was a problem hiding this comment.
Yes.
requireJavaVersionenforce the java version to run maven.- I found that compile failed with jdk 8 (and test target is 11).
- Java 21 satisfies
requireJavaVersion 11.
- The bytecode version of binary is controlled by
javac targetoption.
The guarantee that the built binary can be used by java 8 application, is important for foundational libraries(e.g. javassit).
The CI can check this guarantee with some works:
- build/compile with java 21 or 11(e.g.
maven install) - run test(without compile) on multiple java versions(e.g.
mvn surfire:test) - the test cases that can not run by java 8, should be skipped conditionally(by test case/framework config).
I do this(build by java high version and run test by java low versions in CI/GitHub actions) in some projects, e.g. https://github.com/alibaba/transmittable-thread-local/actions/runs/7358077464/job/20030750510#step:7:206
I can try to add this to the CI/GitHub actions of javassist project with honor.
There was a problem hiding this comment.
I found that compile failed with jdk 8 (and test target is 11).
This is correct. Some features are only for Java 11 and above.
inceptionYearelement, and use it incopyright bottommaven-gpg-pluginmore stable build and fix related warning message
maven-enforcer-pluginmore straightforward build error message and fast-failed when
maven/javaversion is not satisfied