Fix image viewer crash for still experiments introduced in dials#2556

jbeilstenedmands · Jan 31, 2024 · f743a45 · f743a45
1 parent 7b19b5f
commit f743a45
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/newsfragments/XXX.bugfix b/newsfragments/XXX.bugfix
@@ -0,0 +1 @@
+``dials.image_viewer``: Fix for stills experiments viewing crash introduced in #2556
diff --git a/src/dials/util/image_viewer/spotfinder_frame.py b/src/dials/util/image_viewer/spotfinder_frame.py
@@ -263,8 +263,8 @@ def __init__(self, *args, **kwds):
                 self.viewing_stills = False
                 break
         for experiment_list in self.experiments:
-            if any(
-                exp.scan and (exp.scan.get_oscillation()[1] != 0.0)
+            if not all(
+                exp.scan and (exp.scan.get_oscillation()[1] == 0.0)
                 for exp in experiment_list
             ):
                 self.viewing_still_scans = False
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		``dials.image_viewer``: Fix for stills experiments viewing crash introduced in #2556