Fix #744: Bulk messages with aoiapns not working properly #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashimJVZ
reviewed
Nov 21, 2024
mikaelengstrom
force-pushed
the
fix-bulk-messaging-for-aioapns
branch
from
d69a18c to
5c24247
Compare
Previous version implemented aioapns in a way that made it hang indefinetly. Especially when receiver list contaned a lot of bad tokens. Having a lot of bad tokens still affects the reliability and transfer speed of notification sets, which is why this fix also deactivate devices for error codes BadDeviceToken and DeviceTokenNotForTopic unlike previous versions.
mikaelengstrom
force-pushed
the
fix-bulk-messaging-for-aioapns
branch
from
5c24247 to
59ab2c6
Compare
|
Would be thankful if for example @50-Course could look into this since you managed the last PR by @pomali |
50-Course
reviewed
Dec 6, 2024
There was a problem hiding this comment.
hi @mikaelengstrom. apologies, couldn't make a comment back yesterday - as the notification came in amid few things. i understand the intent behind this change, however, can we have a test suite to ensure this doesn't break things down the line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version implemented aioapns in a way that made it hang indefinetly. Especially when receiver list contaned a lot of bad tokens.
Having a lot of bad tokens still affects the reliability and transfer speed of notification sets, which is why this fix also deactivate devices for error codes BadDeviceToken and DeviceTokenNotForTopic unlike previous versions.
Tagging @pomali who initially did the aoiapns integration in case you have any feedback.