-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python backend and update README #71
Conversation
added python implementation for this for API request type use-case
added screenshots
updated the design
please add me to the contributors , i want to make it more elegant and functional (this repo.) |
Hi @hemangjoshi37a! I'll need to find some time to take a proper look, especially for the Readme updates. Thanks for those! After taking a quick look at your changes, I do have some questions, mostly: what problem do you think using Python in this way solves? With my current version you can just open the Your version using Python seems to mostly add a lot of overhead: you need to have python installed with multiple dependencies (Flask, PIL and Numpy) to in the end get a simplified version of what the current tool can already do. In contrast; the only 'dependency' of the current version is a webbrowser. I can imagine it being useful to some to have an img2cpp Python module that allows you to convert images, but in that case I'd expect it to be a proper module that you can import into your own projects, and for the Python script to also work standalone via commandline arguments (i.e. So I'm wondering how you see this version being used, compared to the original approach of having a static website with just a |
Hi there, |
I wrote a whole reply, but messed up and it didn't get posted, so lets try again... The layout in that image does look a lot better already :) I'd really like to declutter the interface, but I'd also like not to clutter the code too much, which means I won't be merging the Python port at this point, as I feel it will add too much complexity without adding a lot of benefit at this point. I'd love to merge this once the Python part is fully fleshed out and has all the same functionality / can be used in the way I described before. Some quick notes on some small 'problems' with the current PR. I really don't want to discourage you from adding to image2cpp, so please take this as constructive feedback :)
Please do take a look at the https://github.com/javl/image2cpp/blob/main/LICENSE.md for image2cpp. Porting it to Python is perfectly fine, so is using it commercially, but you do need to link back to the original / give credit from projects where it is used, like your payment application. Also, when used in commercial projects, I always encourage to use the donate button ;) |
Sorry i am not interested in working with you. please dont consider this PR. |
I hope it's not because of my feedback? |
This commit introduces a new Python backend for enhanced image conversion
functionality and updates the README to reflect these changes.
New features:
README updates:
Technical changes:
This PR aims to expand the project's capabilities and improve its
presentation to potential users and contributors.