Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removal of Guava from java-json-tools repos #11

Open
Capstan opened this issue Sep 5, 2019 · 5 comments
Open

Consider removal of Guava from java-json-tools repos #11

Capstan opened this issue Sep 5, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@Capstan
Copy link

Capstan commented Sep 5, 2019

Spurred by @soberich in pr #3 and @trajano in fge/uri-template#4:

  • Guava is heavyweight for small web apps.
  • Guava does deprecate and remove classes/methods/enums/etc., and this limits the ability of clients of these libraries to use a more modern Guava unless we keep up.
  • A CVE in Guava has been a forcing function to use a more modern Guava.
  • Guava itself may force upon this project minimum JDK standards.

Guava is currently used in this repo, in https://github.com/java-json-tools/json-schema-core, and in https://github.com/fge/uri-template, which is a dependency of -core. Not sure if we should consider them separately or not, but -core cannot be rid of a transitive Guava dependency without all of them being rid of Guava.

/cc @huggsboson

@Capstan
Copy link
Author

Capstan commented Jan 6, 2020

I have created a v1.x branch for jackson-coreutils to track any maintenance fixes we need, as #42 requires us bumping the major version number.

@Capstan
Copy link
Author

Capstan commented Jan 7, 2020

See also java-json-tools/json-patch#18

@asoldano
Copy link

@Capstan hi, when is next release from master planned for? Thanks

@Capstan
Copy link
Author

Capstan commented May 26, 2020

So, I'm about to release a jackson-coreutils v2.0 w/o Guava. That will allow a follow-on update of json-patch also w/o Guava.

That said, uri-template still has Guava in it, and fge/uri-template#5 creating local Guava copies of certain files isn't something I'm particularly interested in accepting. Furthermore, json-schema-core also still has lots of tendrils, so this isn't a solution for those of you wanting json-schema-validator to be Guava-free.

@lukeu
Copy link

lukeu commented May 17, 2024

* Guava does deprecate and remove classes/methods/enums/etc., and this limits the ability of clients of these libraries to use a more modern Guava _unless_ we keep up.

Just to say: since v21, Guava has vowed to avoid removing non-Beta APIs (unless absolutely forced to for security reasons):

https://github.com/google/guava/wiki/PhilosophyExplained#non-beta-apis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants