Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider updating JDK version for java-json-tools repos #12

Closed
Capstan opened this issue Sep 5, 2019 · 6 comments
Closed

Consider updating JDK version for java-json-tools repos #12

Capstan opened this issue Sep 5, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@Capstan
Copy link

Capstan commented Sep 5, 2019

JDK 1.6 is hard to build on these days:

We should consider upgrading the JDK, presumably to JDK 1.8.

Things to consider:

  • Do we bump the major version number given that the source compatibility would change? JDK 1.6 Compatibility guide
  • Do we want to target JDK 1.7 for Android support? I know very little about this save that https://github.com/google/guava has different dependencies for Android vs. the JRE, and right now we're using the JRE (which might interfere with our Android clients; don't know the details).

/cc @huggsboson

@Capstan Capstan added the enhancement New feature or request label Sep 5, 2019
@Capstan
Copy link
Author

Capstan commented Sep 5, 2019

Asked a question in google/guava#3595 about how downstream projects are expected to provide JRE vs. Android support if they're Guava consumers.

@Capstan
Copy link
Author

Capstan commented Sep 10, 2019

@Capstan
Copy link
Author

Capstan commented Sep 10, 2019

Per advice on google/guava#3595, posted a question on StackOverflow.

@cpovirk
Copy link

cpovirk commented Sep 11, 2019

  • Do we bump the major version number given that the source compatibility would change?

I don't know whether there's a settled answer to this, so I am replying half to link to this Google Cloud proposed best practice, which suggests not bumping, and half to subscribe to this thread to hear if other people have recommendations to the contrary :)

@Capstan
Copy link
Author

Capstan commented Sep 12, 2019

Given @cpovirk's advice, I propose:

  • We switch the reference to Guava from the JRE-flavor to the Android-flavor (and people can use it with the JRE anyway).
  • We update the source/target compatibility to 1.7, since it's enforced by our use of Guava.
  • We only bump the minor release # instead of the major release #, because 1.6 is essentially end-of-life.
  • We remove any uses of deprecated and removed symbols so that we can upgrade all the java-json-tools to 28.1-android, rather than being unfortunately pinned back at 25.

Feedback accepted until end of September, after which point I'll make the requisite changes.

Capstan added a commit to Capstan/btf that referenced this issue Oct 29, 2019
Capstan added a commit to java-json-tools/btf that referenced this issue Oct 29, 2019
Capstan added a commit to Capstan/msg-simple that referenced this issue Oct 29, 2019
Capstan added a commit to java-json-tools/msg-simple that referenced this issue Oct 29, 2019
Capstan added a commit to Capstan/uri-template that referenced this issue Oct 29, 2019
Capstan added a commit to Capstan/uri-template that referenced this issue Oct 29, 2019
Capstan added a commit to Capstan/uri-template that referenced this issue Oct 29, 2019
Capstan added a commit to java-json-tools/uri-template that referenced this issue Oct 29, 2019
Capstan added a commit to Capstan/jackson-coreutils that referenced this issue Oct 29, 2019
@Capstan Capstan mentioned this issue Oct 29, 2019
Capstan added a commit that referenced this issue Oct 29, 2019
Capstan added a commit to Capstan/json-schema-core that referenced this issue Oct 29, 2019
Capstan added a commit to java-json-tools/json-schema-core that referenced this issue Oct 29, 2019
Capstan added a commit to Capstan/json-schema-validator that referenced this issue Oct 29, 2019
Capstan added a commit to java-json-tools/json-schema-validator that referenced this issue Oct 29, 2019
Capstan added a commit to Capstan/uri-template that referenced this issue Oct 30, 2019
Capstan added a commit to java-json-tools/uri-template that referenced this issue Oct 30, 2019
Capstan added a commit to Capstan/jackson-coreutils that referenced this issue Oct 30, 2019
Capstan added a commit to Capstan/json-schema-core that referenced this issue Oct 30, 2019
Capstan added a commit that referenced this issue Oct 30, 2019
Capstan added a commit to Capstan/json-schema-validator that referenced this issue Oct 30, 2019
See java-json-tools/jackson-coreutils/issues/12.

Also added missing compile dependency that was luckily fulfilled by dependencies.
Capstan added a commit to Capstan/json-schema-validator that referenced this issue Oct 30, 2019
See java-json-tools/jackson-coreutils/issues/12.

Also added missing compile dependency that was luckily fulfilled by dependencies.
Capstan added a commit to java-json-tools/json-schema-core that referenced this issue Oct 30, 2019
Capstan added a commit to java-json-tools/json-schema-validator that referenced this issue Oct 30, 2019
See java-json-tools/jackson-coreutils/issues/12.

Also added missing compile dependency that was luckily fulfilled by dependencies.
@Capstan
Copy link
Author

Capstan commented Oct 30, 2019

All that is left is bumping the minor version, which we'll do upon the next release.

@Capstan Capstan closed this as completed Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants