-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use multivariate as default for follow-up tests RM ANOVA #319
Use multivariate as default for follow-up tests RM ANOVA #319
Conversation
The reason for the change in default makes sense. That being said,
Please add (at least) one new test with |
@vandenman
|
There are some unit test failures, for example, Failure ('test-anovarepeatedmeasures.R:1107:3'): Ordinal restrictions: Between factor marginal means table results match
The `test` argument provided to `expect_equal_tables()` is empty. Likely reason: the last run of jaspTools exited with a fatalError:
This analysis terminated unexpectedly. Error in length(options[['restrictedMarginalMeanTerms']]) = 0 || options[['restrictedMarginalMeanTerms']] = : 'length = 2' in coercion to 'logical(1)' are these unrelated? If so, it would probably be good to fix these in a separate PR (I can take a look at that). |
Curious to see if the marginal means for RM ANOVA are now fixed (hopefully for all, but maybe only for mac?), since it passes locally. |
@vandenman I ended up removing all gorica fixes, will put them in a separate PR. For now the unit tests are only failing on some marginal means things.. shall we merge this? |
While setting this to "false" is in line with SPSS, the multivariate option is generally considered to be more appropriate since it handles deviations from sphericity better. See also the thread here, with a discussion between the authors of the emmeans and afex packages.
While we have added this option for a while now, I think it's best to make this the default option. I tweaked the unit tests such that those still use the univariate model, although I could also update them such that they use the multivariate tests, but then the results themselves need to be updated.
Fix jasp-stats/jasp-issues#1221
Fix jasp-stats/jasp-issues#1642