Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for text-based commands #93

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

jasonlessenich
Copy link
Owner

@jasonlessenich jasonlessenich commented Nov 29, 2022

Pull Request Etiquette

  • I have checked the PRs for upcoming features/bug fixes.

Changes

  • Internal code
  • Documentation
  • Examples
  • Other: _____

Closes Issue: #58

Description

This PR introduces text-based commands

@jasonlessenich jasonlessenich marked this pull request as draft November 29, 2022 22:24
@DenuxPlays DenuxPlays added the new feature New feature (request). label Nov 29, 2022
@DenuxPlays DenuxPlays linked an issue Nov 29, 2022 that may be closed by this pull request
1 task
@DenuxPlays
Copy link
Collaborator

DenuxPlays commented Nov 29, 2022

Can you also add hybrid commands in this pr?
#59

@jasonlessenich
Copy link
Owner Author

dunno if I put them in this pr since text commands itself are already quite a big thing to implement

@DenuxPlays
Copy link
Collaborator

dunno if I put them in this pr since text commands itself are already quite a big thing to implement

Alright 👍

* This method can be accessed from the {@link DIH4JDA} instance.
* <br>This is automatically executed each time the {@link ListenerAdapter#onReady(net.dv8tion.jda.api.events.session.ReadyEvent)} event is executed.
* (can be disabled using {@link DIH4JDABuilder#disableAutomaticCommandRegistration()})
*/
public void registerInteractions() {
public void registerCommands() {
Copy link
Collaborator

@DenuxPlays DenuxPlays Feb 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a breaking change for the user?

@DenuxPlays DenuxPlays mentioned this pull request Feb 14, 2023
6 tasks
# Conflicts:
#	src/main/java/xyz/dynxsty/dih4jda/DIH4JDA.java
#	src/main/java/xyz/dynxsty/dih4jda/DIH4JDALogger.java
#	src/main/java/xyz/dynxsty/dih4jda/events/DIH4JDAEvent.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature (request).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Text Commands
2 participants