Mark inner classes static that don't reference parent class.

jasonab · Jun 29, 2011 · 3abaf71 · 3abaf71
1 parent 6c3ec9f
commit 3abaf71
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/redis/clients/jedis/ShardedJedisPipeline.java b/src/main/java/redis/clients/jedis/ShardedJedisPipeline.java
@@ -10,7 +10,7 @@ public abstract class ShardedJedisPipeline {
     private BinaryShardedJedis jedis;
     private List<FutureResult> results = new ArrayList<FutureResult>();
 
-    private class FutureResult {
+    private static class FutureResult {
         private Client client;
 
         public FutureResult(Client client) {

diff --git a/src/main/java/redis/clients/util/JedisByteHashMap.java b/src/main/java/redis/clients/util/JedisByteHashMap.java
@@ -88,7 +88,7 @@ public Collection<byte[]> values() {
         return internalMap.values();
     }
 
-    private final class ByteArrayWrapper {
+    private static final class ByteArrayWrapper {
         private final byte[] data;
 
         public ByteArrayWrapper(byte[] data) {
@@ -110,7 +110,7 @@ public int hashCode() {
         }
     }
 
-    private final class JedisByteEntry implements Entry<byte[], byte[]> {
+    private static final class JedisByteEntry implements Entry<byte[], byte[]> {
         private byte[] value;
         private byte[] key;