-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Platform.io and ESP32 - Including a few bug-fixes #37
Open
exetico
wants to merge
32
commits into
jascdk:master
Choose a base branch
from
exetico:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Total -- 389.27kb -> 291.22kb (25.19%) /Home Assistant/HA_GUI.png -- 142.98kb -> 95.73kb (33.05%) /Esphome/nilan_display.png -- 182.25kb -> 139.29kb (23.57%) /images/nilan-plug.jpg -- 56.88kb -> 49.67kb (12.68%) /Home Assistant/ventilation.png -- 4.83kb -> 4.29kb (11.24%) /images/overview.svg -- 2.33kb -> 2.24kb (3.65%) Signed-off-by: ImgBotApp <[email protected]>
[ImgBot] Optimize images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added support for ESP32, and updated a few things in the platform.io solution implemented by #30. Thank you for the work, to both of you.
I've also used Serial2 for my project, so that's how it's in the code.
This closes #27, which I originally submitted. It turned out to be a combination of a bad board, but also, a wirering issues, in the solution where I jumped in and helped with the compile (and so).