-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future code base components? (python 3.12 / pyproject.toml vs setup.py / poetry vs pip-pipenv-twine-... / docker improvements) #181
base: master
Are you sure you want to change the base?
Conversation
…mportlib.metadata and their backports (importlib_resources, importlib_metadata).
…of using the Pyproject.toml in favour of setup.py and setup.cfg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've taken a quick look and appreciate the changes overall. However, I have a few concerns about releasing with GitHub Actions that could use some improvement.
In summary:
- We should eliminate do_release.sh.
- The release version should be taken directly from Git tags, as it currently works this way.
- Running Docker as a non-root user is a significant advantage.
Unfortunately, I’ll have limited availability over the next two weeks.
Thx for taking the time already, I don't think we need to rush this, nothing is on fire atm. |
It's at a point now where I think the building and publishing of both package & container image should work (triggered from the Github create-new-release function). I am not sure if you would be able to test that separately. The non-root user / python 3.12 requirement still introduces some breaking changes to end users setups so extra steps need to be taken to tackle this. |
Right we are getting somewhere, lot's of changes in the readme and covering all items in #133 . I am moving my own install over to containers built from https://github.com/stynoo/withings-sync to test the changes. Please have a look, especially at the way the readme is progressing and let me know what you think (at your convenience ofc). |
When working on the last PR I came across the statements that "The recommended way of using Setuptools has shifted in the direction of using the pyproject.toml in favour of setup.py and setup.cfg."
Combining this with "pkg_resources is deprecated" in python 3.12 and the docker wishlist in #133 I realized that we probably will have to introduce some breaking changes in the future.
Hence introducing this PR, primarily as a proposition of a possible way forwards. This introduces the following changes:
Again, this will introduce breaking changes, this PR is incomplete but I wanted to share this early to start a discussion/collaboration. If this is not the correct way forwards or not what you envisioned, just let me know.
todo:
Need help with Kubernetes/K8s files in /contrib