Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leaks fixed #515

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Memory leaks fixed #515

wants to merge 2 commits into from

Conversation

vinaynb
Copy link

@vinaynb vinaynb commented Apr 4, 2016

Removed unnecessary references to triggerElement and spacer element which were leaking memory and were leading to large number of detached dom nodes in case of single page apps such as angular.

Fixes #510

vinaynb and others added 2 commits April 4, 2016 16:46
@vinaynb
Fixed memory leaks
8bc614f 
Removed unncessary references to triggerElement and spacer element which were leaking memory and were leading to large number of detached dom nodes in case of single page apps such as angular.
@vinaynb
Update core.js
80de77a 
removed extra tab space
@vinaynb
Copy link
Author

vinaynb commented Apr 4, 2016

Travis builds fail due to Karma module error

Error: No provider for "framework:requirejs"! (Resolving: framework:requirejs)

[11:30:41] Starting Karma server...
WARN [plugin]: Error during loading "/home/travis/build/janpaepke/ScrollMagic/node_modules/karma-requirejs" plugin:
  Cannot find module 'requirejs'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
investigate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinaynb @janpaepke