Fixed centered pin offset problem #403
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a pin is horizontally centered and its width is fixed (or auto width), taking it out of document flow by setting its position to fixed would cause the pin spacer to collapse to 0. The left offset of the pin spacer moves to the right because its width is now zero. This causes the pin to jump to the right as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a pin is horizontally centered and its width is fixed (or auto
width), taking it out of document flow by setting its position to fixed
would cause the pin spacer to collapse to 0.
The left offset of the pin spacer moves to the right because its width
is now zero. This causes the pin to jump to the right as well.
See a demo of this problem: http://codepen.io/hayeah/pen/GppjgN