Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add json schema for engine and model parameters #840

Merged
merged 4 commits into from
Dec 8, 2023
Merged

docs: add json schema for engine and model parameters #840

merged 4 commits into from
Dec 8, 2023

Conversation

tikikun
Copy link
Contributor

@tikikun tikikun commented Dec 4, 2023

No description provided.

@tikikun tikikun self-assigned this Dec 4, 2023
@tikikun tikikun linked an issue Dec 4, 2023 that may be closed by this pull request
feat: json schema for frontend parameters #813
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023 •
edited
Loading

Preview URL: https://cc626b8c.jan-qn8.pages.dev

@tikikun tikikun marked this pull request as draft December 4, 2023 10:58
@hiro-v
Copy link
Contributor

hiro-v commented Dec 4, 2023

You should add here instead: https://github.com/janhq/jan/blob/main/docs/openapi/specs/models.yaml
This applies to all changes @tikikun

@hiro-v hiro-v requested a review from a team December 4, 2023 19:11
@hiro-v hiro-v added P0: critical Mission critical type: discussion type: docs Improvements or additions to documentation type: enhancement Improves a current feature labels Dec 4, 2023
@dan-homebrew
Copy link
Contributor

dan-homebrew commented Dec 5, 2023 •
edited
Loading

@vuonghoainam @tikikun Quick question - are we able to embed or reference a JSON schema as part of a Swaggerfile?

cc @hieu-jan

@tikikun
Copy link
Contributor Author

tikikun commented Dec 5, 2023

You should add here instead: https://github.com/janhq/jan/blob/main/docs/openapi/specs/models.yaml This applies to all changes @tikikun

Doesn't look right since this is value range for the model and engine section

@tikikun tikikun marked this pull request as ready for review December 5, 2023 12:04
@louis-jan louis-jan changed the title add json schema for engine and model parameters docs: add json schema for engine and model parameters Dec 6, 2023
@louis-jan louis-jan mentioned this pull request Dec 8, 2023
Closed
@tikikun tikikun merged commit ca0ad7d into main Dec 8, 2023
1 check passed
@tikikun tikikun deleted the 813-feat-json-schema-for-frontend-parameters branch December 8, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@freelerobot freelerobot freelerobot approved these changes

Assignees

@tikikun tikikun

Labels
P0: critical Mission critical type: docs Improvements or additions to documentation type: enhancement Improves a current feature
Projects
Jan & Cortex
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: json schema for frontend parameters
5 participants
@tikikun @hiro-v @dan-homebrew @freelerobot @louis-jan