Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revamp thread screen #802

Merged
merged 27 commits into from
Dec 4, 2023
Merged

feat: revamp thread screen #802

merged 27 commits into from
Dec 4, 2023

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Dec 1, 2023

  • Thread screen is default screen
  • Screen blank state when user have not any model
  • Change create thread using icon instead of button
  • Update ribbon menu icon
  • Update Message toolbar height when user typing long message
  • Add default avatar placeholder
  • Update message action toolbar
  • Update right panel visual to latest design on Figma
  • New component select or dropdown
  • Initial system monitor screen
  • Move list downloaded model into settings screen

@freelerobot freelerobot added the type: enhancement Improves a current feature label Dec 1, 2023
@urmauur urmauur force-pushed the feat/thread-screen branch 2 times, most recently from 5a71157 to 76114ca Compare December 1, 2023 14:57
@urmauur urmauur requested review from namchuai and louis-jan and removed request for namchuai December 2, 2023 03:56
@urmauur urmauur force-pushed the feat/thread-screen branch 2 times, most recently from 99bb1b4 to c690413 Compare December 3, 2023 04:54
@urmauur urmauur marked this pull request as ready for review December 3, 2023 05:49
@freelerobot
Copy link
Contributor

freelerobot commented Dec 3, 2023

@urmauur I think the dropdown icon is reversed.

  • ^ is when the section is collapsed. Clicking on it should open the section
  • v is when the section is opened. Clicking on it should close the section

See below:

image In this state, the icon should be `v` instead of `^`

@urmauur urmauur force-pushed the feat/thread-screen branch from 32abc49 to 8f9e399 Compare December 3, 2023 09:35
@louis-jan louis-jan merged commit 424b003 into main Dec 4, 2023
3 checks passed
@louis-jan louis-jan deleted the feat/thread-screen branch December 4, 2023 03:55
@imtuyethan
Copy link
Contributor

@0xSage actually the current one is correct:
^ is when the section is opened.
v is when the section is collapsed

Screenshot 2023-12-04 at 5 11 02 PM

Ref: https://carbondesignsystem.com/components/accordion/usage/

@freelerobot
Copy link
Contributor

@imtuyethan you are right, I was wrong about the direction.

I did a lot of googling, but this seems to sum it up from a vernacular standpoint:
https://ux.stackexchange.com/questions/117866/what-expand-collapse-representation-is-correct

My apologies @urmauur is it possible to switch it back.

@urmauur
Copy link
Member Author

urmauur commented Dec 4, 2023

@0xSage @imtuyethan okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improves a current feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants