Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: model plugin to follow new specs #682

Merged
merged 2 commits into from
Nov 29, 2023
Merged

refactor: model plugin to follow new specs #682

merged 2 commits into from
Nov 29, 2023

Conversation

namchuai
Copy link
Contributor

@namchuai namchuai commented Nov 22, 2023 •
edited
Loading

Fixes: #730

  • Creating new chat with Jan assistant
Screenshot 2023-11-24 at 16 40 44 Screenshot 2023-11-24 at 16 39 13
  • Storing messages as separate file messages.jsonl
Screenshot 2023-11-24 at 16 41 46

@namchuai namchuai force-pushed the feat/662 branch 2 times, most recently from 4e040f7 to 71106bd Compare November 22, 2023 13:11
@louis-jan
Copy link
Contributor

Love it! Great work ⚡️ @namchuai 🚀

@namchuai namchuai force-pushed the feat/662 branch 2 times, most recently from a6cb436 to c0fb6ec Compare November 23, 2023 02:45
@namchuai namchuai marked this pull request as ready for review November 23, 2023 02:57
@namchuai namchuai marked this pull request as draft November 24, 2023 09:37
@namchuai namchuai self-assigned this Nov 24, 2023
@louis-jan louis-jan added type: epic A major feature or initiative type: feature request A new feature and removed type: feature request A new feature labels Nov 24, 2023
@louis-jan
Copy link
Contributor

cc @urmauur, we will need your help on the thread settings (right panel)

@louis-jan
Copy link
Contributor

louis-jan commented Nov 24, 2023 •
edited
Loading

NOTES: there will be model settings section for remote model (API_KEY...) cc @vuonghoainam

@louis-jan louis-jan added the type: feature request A new feature label Nov 27, 2023
@louis-jan louis-jan added this to the v0.4.0 milestone Nov 27, 2023
@namchuai namchuai force-pushed the feat/662 branch 6 times, most recently from 2dd1a72 to edb4661 Compare November 28, 2023 02:51
@louis-jan louis-jan force-pushed the feat/662 branch 2 times, most recently from dac2fb3 to 9d0fa64 Compare November 28, 2023 08:53
@louis-jan louis-jan force-pushed the feat/662 branch 2 times, most recently from 930a0ba to 6217a9c Compare November 28, 2023 09:53
@namchuai namchuai marked this pull request as ready for review November 29, 2023 03:02
@louis-jan louis-jan force-pushed the feat/662 branch 3 times, most recently from e7f8275 to 07f8446 Compare November 29, 2023 04:24
@louis-jan
chore: rebase main
4894c43 
chore: rebase main
louis-jan
louis-jan approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@louis-jan louis-jan merged commit 86e693b into main Nov 29, 2023
3 checks passed
@louis-jan louis-jan deleted the feat/662 branch November 29, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees

@namchuai namchuai

Labels
type: epic A major feature or initiative type: feature request A new feature
Projects
Jan & Cortex
Archived in project
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

epic: Refactored Threads & Messages Extension
2 participants
@namchuai @louis-jan