fix: scroll bottom when generation text

[urmauur]

Describe Your Changes

The changes in this Git diff can be summarized as follows:

1. Use of requestAnimationFrame:

   • Removed the requestAnimationFrame calls from two places where scrolling is performed. This was used to schedule the scroll operation to occur optimally in the browser's next repaint cycle.

2. Direct Scrolling:

   • The code now directly calls scrollTo on parentRef.current without wrapping it in a requestAnimationFrame. This may have been done to simplify the logic or because the timing provided by requestAnimationFrame wasn't necessary.

3. Dependency Array Modifications in useEffect:

   • Added currentThread?.id to the dependency array of both useEffect hooks. This ensures that the effects are re-executed whenever currentThread?.id changes, which might be to ensure that the scrolling logic considers a change in the thread being viewed.

4. Code Simplification:

   • The changes result in simpler effect logic by removing the additional requestAnimationFrame wrapping, under the assumption that immediate execution provides the desired behavior without visual issues like jank.

Overall, these changes simplify the scrolling logic in the ChatBody component by removing unnecessary scheduling of the scroll operation and making the effects more responsive to changes in the currentThread.

Fixes Issues

• Closes QA: Jan 0.5.12 Release Sign-off #4291 (comment)
• Closes #

Self Checklist

• Added relevant comments, esp in complex areas
• Updated docs (for bug fixes / features)
• Created issues for follow-up changes or refactoring needed

[github-actions]

Barecheck - Code coverage report

Total: 68.66%

Your code coverage diff: -0.08% ▾

Uncovered files and lines

File	Lines
web/screens/Thread/ThreadCenterPanel/ChatBody/index.tsx	24-25, 27-28, 30, 34-35, 38-39, 41, 43, 47, 64-69, 71-72, 75-76, 81, 83-84, 88-91, 95-98, 102-105, 109-113, 117, 119, 124-126, 132, 134, 136-137, 139-141, 143-144, 148-150, 152, 189

[louis-jan]

LGTM

[github-actions]

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.