Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update thread's title edge cases #4320

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

louis-jan
Copy link
Contributor

Describe Your Changes

  • Fixed an issue where editing the titles of other threads might not work due to incorrect assistant accessibility for the thread.

Self Checklist

This pull request includes a small but important change to the useCreateNewThread hook in the web/hooks/useCreateNewThread.ts file. The change ensures that the setActiveAssistant function is only called if the thread.assistants array is not empty, which prevents potential errors when the array is empty or undefined.

  • web/hooks/useCreateNewThread.ts: Updated the useCreateNewThread hook to check if thread.assistants is non-empty before calling setActiveAssistant and updateAssistantCallback.

@louis-jan louis-jan requested a review from urmauur December 23, 2024 07:11
@github-actions github-actions bot added the type: bug Something isn't working label Dec 23, 2024
Copy link
Contributor

Barecheck - Code coverage report

Total: 68.61%

Your code coverage diff: 0.01% ▴

Uncovered files and lines
FileLines
web/hooks/useCreateNewThread.ts147-148, 150-151, 158-159, 170, 179, 216, 220, 222

Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@louis-jan louis-jan merged commit 9c4dcd3 into main Dec 23, 2024
21 checks passed
@louis-jan louis-jan deleted the fix/edit-thread-title-edge-cases branch December 23, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants