Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dynamic input box width and remove tooltip image option #4315

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix: dynamic input box width and remove tooltip image option #4315

merged 1 commit into from
Dec 23, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Dec 23, 2024

Describe Your Changes

  1. Remove tooltip and make image optios disabled
    CleanShot 2024-12-23 at 11 01 38

  2. Input box width depend on preference setting
    CleanShot 2024-12-23 at 11 11 23

CleanShot 2024-12-23 at 11 09 36

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: bug Something isn't working label Dec 23, 2024
@urmauur urmauur added this to the v0.5.12 milestone Dec 23, 2024
@urmauur urmauur requested a review from louis-jan December 23, 2024 04:15
@urmauur urmauur self-assigned this Dec 23, 2024
@urmauur urmauur changed the base branch from dev to main December 23, 2024 04:15
@urmauur urmauur changed the title Fix/input box image vision fix: dynamic input box width and remove tooltip image option Dec 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Barecheck - Code coverage report

Total: 68.6%

Your code coverage diff: -0.10% ▾

Uncovered files and lines
FileLines
web/screens/Thread/ThreadCenterPanel/index.tsx42, 44, 47, 50, 53, 83-84, 89-90, 94, 96, 99, 102-103, 111-114, 116-118, 126, 129-130, 132, 134, 140, 146-147, 167, 169
web/screens/Thread/ThreadCenterPanel/ChatInput/index.tsx81, 89, 95, 100, 113-117, 127-129, 134, 137, 163, 172, 178, 180, 243-245, 263-265, 294, 318, 370-372, 374-376, 378-380, 382-384, 397

@github-actions GitHub Actions
Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@urmauur urmauur merged commit abb718c into main Dec 23, 2024
21 checks passed
@urmauur urmauur deleted the fix/input-box-image-vision branch December 23, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees

@urmauur urmauur

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v0.5.12
Development

Successfully merging this pull request may close these issues.

QA: Jan 0.5.12 Release Sign-off
2 participants
@urmauur @louis-jan