Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update scroll issue and copywritting #4305

Closed
wants to merge 7 commits into from
Closed

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Dec 20, 2024

Describe Your Changes

  1. ModelDropdown Component:

    • Text changes in the ModelDropdown component were made to the rendering of selected models.
    • Updated text from "Select Model" to "Select a model," both in a <span> element and as an Input placeholder.
  2. EmptyThread Component:

    • Simplified the text in the EmptyThread component's paragraph.
    • Changed the sentence "You don't have a local model yet." to "You don't have any model".
  3. ChatBody Component:

    • Added imports of isGeneratingResponseAtom and threadStatesAtom from the Thread.atom file.
    • Introduced two new state hooks: threadStates and isGeneratingResponse.
    • Defined isStreamingResponse to check if any threads are waiting for a response.
    • Added an effect to handle scrolling when generating responses. This ensures that new messages scroll into view.
    • Adjusted the handleScroll function logic to account for isStreamingResponse. The scroll behavior now prevents default actions if the user is manually scrolling up, ensuring that automatic scrolling doesn't interrupt user interactions.

Overall, these changes primarily focus on UI text revisions and improving the chat response handling process in the ChatBody component.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: bug Something isn't working label Dec 20, 2024
@urmauur urmauur requested a review from louis-jan December 20, 2024 06:25
@urmauur urmauur self-assigned this Dec 20, 2024
@urmauur urmauur added this to the v0.5.12 milestone Dec 20, 2024
Copy link
Contributor

github-actions bot commented Dec 20, 2024

@urmauur urmauur closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Prompt user to download model, if no models are available
1 participant