Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: display error message from response #4163

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Nov 29, 2024

Describe Your Changes

This PR corrects the error message to display the correct error from the response.

image

Changes made

The changes in the code are in the ModelSearch component, specifically in the error handling section. The toaster function call has been modified:

  • The title previously had a static message: "Oops, you may be rate limited, give it a bit more time".
  • Now, the title is set to the value of errMessage, which dynamically contains the error message.
  • The description property, which used to contain errMessage, has been removed.

This change means that the error message displayed will now be more specific to the error encountered, as the exact error message will be shown in the title.

@github-actions github-actions bot added the type: chore Maintenance, operational label Nov 29, 2024
@louis-jan louis-jan requested a review from a team November 29, 2024 09:45
@imtuyethan imtuyethan added this to the v0.5.10 milestone Nov 29, 2024
@louis-jan
Copy link
Contributor Author

Unstable CI dependencies - Will fix on upstream

@louis-jan louis-jan merged commit 39cdbba into dev Nov 29, 2024
4 of 9 checks passed
@louis-jan louis-jan deleted the fix/display-error-message-from-source branch November 29, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Maintenance, operational
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants