Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove filter on recommend model #4156

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix: remove filter on recommend model #4156

merged 1 commit into from
Nov 28, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Nov 28, 2024

Describe Your Changes

Remove filter engine on hooks recommend model

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added this to the v0.5.10 milestone Nov 28, 2024
@urmauur urmauur requested a review from louis-jan November 28, 2024 14:48
@urmauur urmauur self-assigned this Nov 28, 2024
@github-actions github-actions bot added the type: bug Something isn't working label Nov 28, 2024
Copy link
Contributor

Barecheck - Code coverage report

Total: 69.32%

Your code coverage diff: -0.02% ▾

Uncovered files and lines
FileLines
web/hooks/useRecommendedModel.ts34, 49-50, 52-53, 56, 58-60, 65, 67-68, 72, 76-78, 81-82, 85, 88-89, 92
web/screens/Thread/ThreadLeftPanel/index.tsx55-56, 74-75, 77-78, 80, 94-95, 102, 121, 129, 131, 163, 167, 181, 185, 199, 203

@louis-jan louis-jan merged commit 0c37be3 into dev Nov 28, 2024
11 checks passed
@louis-jan louis-jan deleted the fix/remote-model branch November 28, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants