fix: model params settings local api server #4077
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Slider Component Enhancements:
twMerge
fromtailwind-merge
to conditionally apply Tailwind CSS classes.className
prop of theSliderPrimitive.Root
component to usetwMerge
for dynamic class names based on whether the slider is disabled.Slider Styles:
styles.scss
, making the cursor unavailable and reducing opacity when the slider is disabled.Atom Updates:
LocalAPIserverModelParamsAtom
inLocalServer.atom.ts
.serverEnabledAtom
andselectedModelAtom
across various components to ensure consistency and access to these atoms.Left Panel Enhancements:
@janhq/core
for better type safety.EngineManager
andModel
to manage model loading more effectively.ctx_len
to 4096 if it's greater than 2048.Right Panel Enhancements:
onUpdateParams
to update theLocalAPIserverModelParamsAtom
.disabled
prop is passed down toModelSetting
andEngineSetting
components to reflect the server's enabled status.These changes aim to improve the user interface, enhance type safety, and provide more dynamic control over model settings in a local server environment.
Fixes Issues
Self Checklist