Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump cortex.cpp to latest version - recursively scanning models folder should also include remote models #4052

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

louis-jan
Copy link
Contributor

Describe Your Changes

This PR aims to update cortex.cpp to the latest version, which includes configuration stabilization. This fix resolves an issue where cortex.cpp server occasionally returns an empty models list because it incorrectly locates the data folder.

This PR also include a bug fix where self added remote model.json not available in the models list.

Screenshot 2024-11-20 at 12 35 57

Changes made

The git diff shows changes made to three files in different extensions:

  1. version.txt in inference-cortex-extension/bin:

    • The version string was updated from 1.0.3-rc4 to 1.0.3-rc5.
  2. index.ts in inference-openrouter-extension/src:

    • The transformPayload function was modified:
      • It now checks if payload.model is 'open-router-auto'. If not, it uses payload.model; otherwise, it uses this.model.
  3. index.ts in model-extension/src:

    • Adjusted the logic in filtering legacyModels:
      • Instead of filtering models based on settings?.vision_model, it now filters out models that are already present in fetchedModels based on matching id.

These changes involve version updates, payload adjustments, and logic refinements in model filtering.

@louis-jan louis-jan requested a review from a team November 20, 2024 05:36
@github-actions github-actions bot added the type: bug Something isn't working label Nov 20, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Barecheck - Code coverage report

Total: 69.28%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@louis-jan louis-jan merged commit a4d689e into dev Nov 20, 2024
9 checks passed
@louis-jan louis-jan deleted the fix/customized-remote-model-json-should-be-available branch November 20, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants