Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding create bot functionality #368

Merged
merged 5 commits into from
Oct 23, 2023
Merged

feat: adding create bot functionality #368

merged 5 commits into from
Oct 23, 2023

Conversation

namchuai
Copy link
Contributor

@namchuai namchuai commented Oct 17, 2023 •
edited
Loading

Fixes: #232

  • Add toggling for Chat history (with animation)
  • Add UI for creating bot
  • Map function
Screenshot 2023-10-16 at 18 20 15 Screenshot 2023-10-16 at 18 17 29

@dan-menlo
Copy link
Contributor

@namchuai Looking good!

@freelerobot
Copy link
Contributor

so cool!

@namchuai namchuai force-pushed the add-create-bot branch 2 times, most recently from c554503 to 8af5589 Compare October 18, 2023 17:40
@namchuai namchuai force-pushed the add-create-bot branch 3 times, most recently from 011dc9c to 2de25cb Compare October 19, 2023 15:32
@namchuai namchuai force-pushed the add-create-bot branch 3 times, most recently from 2b19a2a to 5a6d884 Compare October 20, 2023 05:50
@namchuai namchuai temporarily deployed to production October 20, 2023 05:50 — with GitHub Actions Inactive
@louis-jan louis-jan mentioned this pull request Oct 20, 2023
Merged
@namchuai namchuai temporarily deployed to production October 20, 2023 11:07 — with GitHub Actions Inactive
@hiro-v hiro-v requested a review from louis-jan October 22, 2023 01:19
@hiro-v hiro-v added the P0: critical Mission critical label Oct 22, 2023
@hiro-v hiro-v added this to the Jan v1.0.0 milestone Oct 22, 2023
@namchuai namchuai temporarily deployed to production October 22, 2023 18:25 — with GitHub Actions Inactive
@namchuai namchuai temporarily deployed to production October 22, 2023 18:51 — with GitHub Actions Inactive
@namchuai namchuai temporarily deployed to production October 22, 2023 18:58 — with GitHub Actions Inactive
@namchuai namchuai temporarily deployed to production October 22, 2023 22:16 — with GitHub Actions Inactive
@namchuai namchuai temporarily deployed to production October 22, 2023 22:17 — with GitHub Actions Inactive
@namchuai namchuai temporarily deployed to production October 22, 2023 23:37 — with GitHub Actions Inactive
@namchuai namchuai marked this pull request as ready for review October 22, 2023 23:38
@namchuai namchuai temporarily deployed to production October 22, 2023 23:39 — with GitHub Actions Inactive
fix e2e test
0290a4f 
Signed-off-by: James <[email protected]>
@namchuai namchuai temporarily deployed to production October 23, 2023 05:27 — with GitHub Actions Inactive
louis-jan
louis-jan approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

louis-jan
louis-jan reviewed Oct 23, 2023
View reviewed changes
web/app/_components/ToggleSwitch/index.tsx
import { Switch } from "@headlessui/react";
import { Controller } from "react-hook-form";

function classNames(...classes: any) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can import classnames, no need to redefine

@louis-jan
Copy link
Contributor

I will still proceed & merge, @urmauur will help on this

Screenshot 2023-10-23 at 15 56 24

@louis-jan louis-jan merged commit 6e2210c into main Oct 23, 2023
5 checks passed
@louis-jan louis-jan deleted the add-create-bot branch October 23, 2023 08:57
@namchuai namchuai restored the add-create-bot branch October 23, 2023 22:51
@namchuai namchuai deleted the add-create-bot branch October 23, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@urmauur urmauur urmauur approved these changes

Assignees

@namchuai namchuai

Labels
P0: critical Mission critical
Projects
Jan & Cortex
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

epic: Users can create bots (custom model settings)
6 participants
@namchuai @dan-menlo @freelerobot @louis-jan @urmauur @hiro-v