Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: app theme depend on local storage instead native theme electron #1014

Merged
merged 1 commit into from
Dec 14, 2023
Merged

feat: app theme depend on local storage instead native theme electron #1014

merged 1 commit into from
Dec 14, 2023

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Dec 14, 2023

Fixing #926

Description

Remove native theme electron and make theme toggle depend on next-theme based localstorage instead

Test scenario

  • Open app, just make sure theme toggle works well

@github-actions github-actions bot added the type: feature request A new feature label Dec 14, 2023
louis-jan
louis-jan approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY, LGTM

@urmauur urmauur merged commit a83a3d4 into main Dec 14, 2023
5 checks passed
@urmauur urmauur deleted the feat/app-theme branch December 14, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@namchuai namchuai Awaiting requested review from namchuai

Assignees

@urmauur urmauur

Labels
type: feature request A new feature
Projects
Jan & Cortex
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@urmauur @louis-jan