Skip to content

Commit

Permalink
fix: Glitch theme applies on launch.
Browse files Browse the repository at this point in the history
  • Loading branch information
louis-jan committed Nov 30, 2024
1 parent 73d34ea commit 339917c
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 9 deletions.
21 changes: 18 additions & 3 deletions web/helpers/atoms/Setting.atom.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,30 @@ export const janSettingScreenAtom = atom<SettingScreen[]>([])
export const THEME = 'themeAppearance'
export const REDUCE_TRANSPARENT = 'reduceTransparent'
export const SPELL_CHECKING = 'spellChecking'
export const themesOptionsAtom = atom<{ name: string; value: string }[]>([])
export const janThemesPathAtom = atom<string | undefined>(undefined)
export const THEME_DATA = 'themeData'
export const THEME_OPTIONS = 'themeOptions'
export const THEME_PATH = 'themePath'
export const themesOptionsAtom = atomWithStorage<
{ name: string; value: string }[]
>(THEME_OPTIONS, [], undefined, { getOnInit: true })
export const janThemesPathAtom = atomWithStorage<string | undefined>(
THEME_PATH,
undefined,
undefined,
{ getOnInit: true }
)
export const selectedThemeIdAtom = atomWithStorage<string>(
THEME,
'',
undefined,
{ getOnInit: true }
)
export const themeDataAtom = atom<Theme | undefined>(undefined)
export const themeDataAtom = atomWithStorage<Theme | undefined>(
THEME_DATA,
undefined,
undefined,
{ getOnInit: true }
)
export const reduceTransparentAtom = atomWithStorage<boolean>(
REDUCE_TRANSPARENT,
false,
Expand Down
24 changes: 18 additions & 6 deletions web/hooks/useLoadTheme.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { useTheme } from 'next-themes'

import { fs, joinPath } from '@janhq/core'

import { useAtom, useAtomValue, useSetAtom } from 'jotai'
import { useAtom, useAtomValue } from 'jotai'

import cssVars from '@/utils/jsonToCssVariables'

Expand All @@ -20,8 +20,8 @@ type NativeThemeProps = 'light' | 'dark'

export const useLoadTheme = () => {
const janDataFolderPath = useAtomValue(janDataFolderPathAtom)
const setThemeOptions = useSetAtom(themesOptionsAtom)
const setThemePath = useSetAtom(janThemesPathAtom)
const [themeOptions, setThemeOptions] = useAtom(themesOptionsAtom)
const [themePath, setThemePath] = useAtom(janThemesPathAtom)
const [themeData, setThemeData] = useAtom(themeDataAtom)
const [selectedIdTheme, setSelectedIdTheme] = useAtom(selectedThemeIdAtom)
const { setTheme } = useTheme()
Expand Down Expand Up @@ -84,11 +84,23 @@ export const useLoadTheme = () => {
setThemePath,
])

useEffect(() => {
getThemes()
const applyTheme = useCallback(async () => {
if (!themeData || !themeOptions || !themePath) {
await getThemes()
} else {
const variables = cssVars(themeData.variables)
const headTag = document.getElementsByTagName('head')[0]
const styleTag = document.createElement('style')
styleTag.innerHTML = `:root {${variables}}`
headTag.appendChild(styleTag)
}
setNativeTheme(themeData?.nativeTheme as NativeThemeProps)
}, [themeData, themeOptions, themePath, getThemes])

Check warning on line 98 in web/hooks/useLoadTheme.ts

View workflow job for this annotation

GitHub Actions / test-on-windows-pr

React Hook useCallback has a missing dependency: 'setNativeTheme'. Either include it or remove the dependency array

Check warning on line 98 in web/hooks/useLoadTheme.ts

View workflow job for this annotation

GitHub Actions / test-on-macos

React Hook useCallback has a missing dependency: 'setNativeTheme'. Either include it or remove the dependency array

Check warning on line 98 in web/hooks/useLoadTheme.ts

View workflow job for this annotation

GitHub Actions / test-on-ubuntu

React Hook useCallback has a missing dependency: 'setNativeTheme'. Either include it or remove the dependency array

Check warning on line 98 in web/hooks/useLoadTheme.ts

View workflow job for this annotation

GitHub Actions / coverage-check

React Hook useCallback has a missing dependency: 'setNativeTheme'. Either include it or remove the dependency array

useEffect(() => {
applyTheme()
}, [
getThemes,
applyTheme,
selectedIdTheme,
setNativeTheme,
setSelectedIdTheme,
Expand Down

0 comments on commit 339917c

Please sign in to comment.