fix: empty assistant instruction by default

janhq · Dec 5, 2023 · 29d46aa · 29d46aa
1 parent 27b62ed
commit 29d46aa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/extensions/assistant-extension/src/index.ts b/extensions/assistant-extension/src/index.ts
@@ -96,7 +96,7 @@ export default class JanAssistantExtension implements AssistantExtension {
       name: "Jan",
       description: "A default assistant that can use all downloaded models",
       model: "*",
-      instructions: "Your name is Jan.",
+      instructions: "",
       tools: undefined,
       file_ids: [],
       metadata: undefined,

diff --git a/web/hooks/useSendChatMessage.ts b/web/hooks/useSendChatMessage.ts
@@ -59,6 +59,7 @@ export default function useSendChatMessage() {
     const messages: ChatCompletionMessage[] = [
       activeThread.assistants[0]?.instructions,
     ]
+      .filter((e) => e && e.trim() !== '')
       .map<ChatCompletionMessage>((instructions) => {
         const systemMessage: ChatCompletionMessage = {
           role: ChatCompletionRole.System,
@@ -138,6 +139,7 @@ export default function useSendChatMessage() {
     const messages: ChatCompletionMessage[] = [
       activeThread.assistants[0]?.instructions,
     ]
+      .filter((e) => e && e.trim() !== '')
       .map<ChatCompletionMessage>((instructions) => {
         const systemMessage: ChatCompletionMessage = {
           role: ChatCompletionRole.System,