fix: clean downloading model file

janhq · Nov 28, 2023 · 23e2eeb · 23e2eeb
1 parent 2d78b2d
commit 23e2eeb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 16 deletions.
diff --git a/electron/handlers/download.ts b/electron/handlers/download.ts
@@ -34,22 +34,7 @@ export function handleDownloaderIPCs() {
   ipcMain.handle('abortDownload', async (_event, fileName) => {
     const rq = DownloadManager.instance.networkRequests[fileName]
     DownloadManager.instance.networkRequests[fileName] = undefined
-    const userDataPath = app.getPath('userData')
-    const fullPath = join(userDataPath, fileName)
     rq?.abort()
-    let result = 'NULL'
-    unlink(fullPath, function (err) {
-      if (err && err.code == 'ENOENT') {
-        result = `File not exist: ${err}`
-      } else if (err) {
-        result = `File delete error: ${err}`
-      } else {
-        result = 'File deleted successfully'
-      }
-      console.debug(
-        `Delete file ${fileName} from ${fullPath} result: ${result}`
-      )
-    })
   })
 
   /**

diff --git a/plugins/model-plugin/src/index.ts b/plugins/model-plugin/src/index.ts
@@ -56,7 +56,11 @@ export default class JanModelPlugin implements ModelPlugin {
    * @returns {Promise<void>} A promise that resolves when the download has been cancelled.
    */
   async cancelModelDownload(name: string, modelId: string): Promise<void> {
-    return abortDownload(join(JanModelPlugin._homeDir, name, modelId))
+    return abortDownload(join(JanModelPlugin._homeDir, name, modelId)).then(
+      () => {
+        fs.deleteFile(join(JanModelPlugin._homeDir, name, modelId))
+      }
+    )
   }
 
   /**