Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: electron build #908

Merged
merged 2 commits into from
Jul 24, 2024
Merged

fix: electron build #908

merged 2 commits into from
Jul 24, 2024

Conversation

louis-jan
Copy link
Contributor

Describe Your Changes

  • Fixed an issue where cortex-cpp node binding module is broken on Electron build

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan force-pushed the fix/electron-build branch from a784e80 to fafab37 Compare July 24, 2024 05:14
@louis-jan louis-jan merged commit 777f914 into dev Jul 24, 2024
6 checks passed
@louis-jan louis-jan deleted the fix/electron-build branch July 24, 2024 05:30
@louis-jan
Copy link
Contributor Author

Resolve #898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marknguyen1302 marknguyen1302 marknguyen1302 approved these changes

@vansangpfiev vansangpfiev Awaiting requested review from vansangpfiev

@hiento09 hiento09 Awaiting requested review from hiento09

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-jan @marknguyen1302