Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong engine list #890

Merged
merged 3 commits into from
Jul 17, 2024
Merged

fix: wrong engine list #890

merged 3 commits into from
Jul 17, 2024

Conversation

marknguyen1302
Copy link
Contributor

Describe Your Changes

  • Fix undefined engine name
  • Update engine product name, description

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@marknguyen1302 marknguyen1302 requested a review from louis-jan July 17, 2024 10:30
louis-jan
louis-jan reviewed Jul 17, 2024
View reviewed changes
cortex-js/src/infrastructure/providers/cortex/onnx.provider.ts

@Injectable()
export default class Onnxprovider extends CortexProvider {
productName = 'Onnx Inference Engine';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If so, please set name here

@marknguyen1302 marknguyen1302 merged commit 4d16714 into dev Jul 17, 2024
2 checks passed
@marknguyen1302 marknguyen1302 deleted the fix/wrong-engine-list branch July 17, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marknguyen1302 @louis-jan