Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change unload model and model status to POST #558

Merged
merged 3 commits into from
May 14, 2024

Conversation

vansangpfiev
Copy link
Contributor

cortex.llamacpp is now supporting multiple models, we need to change method of unloadmodel and modelstatus to POST.
Sample requests for multiple models feature:
load model:

curl http://localhost:3928/inferences/server/loadmodel \
  -H 'Content-Type: application/json' \
  -d '{
    "llama_model_path": "/model/llama-2-7b-model.gguf",
    "model_alias": "llama-2-7b-model",
    "model_type": "llm" // use 'embedding` for embedding model
  }'

unload model

curl http://localhost:3928/inferences/server/unloadmodel \
  -H 'Content-Type: application/json' \
  -d '{
    "model": "llama-2-7b-model"
  }'

@vansangpfiev vansangpfiev self-assigned this May 14, 2024
@vansangpfiev vansangpfiev requested a review from louis-jan May 14, 2024 02:43
@vansangpfiev vansangpfiev marked this pull request as ready for review May 14, 2024 02:44
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vansangpfiev vansangpfiev merged commit 48dcae3 into dev May 14, 2024
18 checks passed
@vansangpfiev vansangpfiev deleted the feat/get-model-method branch July 8, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants