Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: llama engine #538

Merged
merged 10 commits into from
May 8, 2024
Merged

feat: llama engine #538

merged 10 commits into from
May 8, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented May 3, 2024 •
edited
Loading

Issue: https://github.com/janhq/cortex/issues/516

  • Remove llama.cpp submodule
  • Remove whisper.cpp submodule
  • Add engine.cmake to pull cortex.llamacpp stable release
  • Update build.yml to pack cortex.llamacpp library as well
    TODO: rename nitro to cortex.cpp (?) in another PR

@vansangpfiev vansangpfiev marked this pull request as ready for review May 4, 2024 02:30
@vansangpfiev vansangpfiev self-assigned this May 6, 2024
@vansangpfiev vansangpfiev force-pushed the feat/llama-engine branch 2 times, most recently from c01a6df to a705dba Compare May 7, 2024 04:40
louis-jan
louis-jan approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiento09
Refactor CICD (#546)
1367fc2 
Co-authored-by: Hien To <[email protected]>
@vansangpfiev vansangpfiev merged commit 216097f into dev May 8, 2024
18 checks passed
@vansangpfiev vansangpfiev mentioned this pull request May 9, 2024
Merged
@vansangpfiev vansangpfiev deleted the feat/llama-engine branch July 8, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@tikikun tikikun Awaiting requested review from tikikun

@hiento09 hiento09 Awaiting requested review from hiento09

Assignees

@vansangpfiev vansangpfiev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vansangpfiev @louis-jan @hiento09