Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Update documentation #333

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Feat: Update documentation #333

merged 3 commits into from
Jan 15, 2024

Conversation

hahuyhoang411
Copy link
Contributor

@hahuyhoang411 hahuyhoang411 commented Jan 9, 2024 •
edited
Loading

Problem
Nitro documentation is updated at some points.

Success Criteria
Update Nitro documentation to be up to date.

Additional context

@hahuyhoang411 hahuyhoang411 self-assigned this Jan 9, 2024
@hahuyhoang411 hahuyhoang411 marked this pull request as draft January 9, 2024 09:26
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024 •
edited
Loading

Preview URL: https://cfff2859.nitro-dim.pages.dev

@hahuyhoang411 hahuyhoang411 marked this pull request as ready for review January 15, 2024 02:40
tikikun
tikikun approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@tikikun tikikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tikikun tikikun merged commit 0776047 into main Jan 15, 2024
1 check passed
@hiro-v hiro-v deleted the add/update-docs branch January 30, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tikikun tikikun tikikun approved these changes

@hiro-v hiro-v Awaiting requested review from hiro-v

Assignees

@hahuyhoang411 hahuyhoang411

Labels
P3: nice to have Nice to have feature
Projects
Jan & Cortex
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hahuyhoang411 @tikikun