Chore: Refactor nitro lib #325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duongcongtoai
commented
Jan 8, 2024
•
duongcongtoai
commented
- split header files into include directory
- added a interface target llama_interface, so we can make the import path of llama files more descriptive (log.h -> llama_interface/log.h)
- moved nitro object files into src folder, and use glob to compile all .cpp file, downside is that we have to run cmake . everytime we add new .cpp file
tikikun
reviewed
Jan 23, 2024
CMakeLists.txt
Outdated
| ${CMAKE_THREAD_LIBS_INIT}) | ||
| # find_package(Drogon CONFIG REQUIRED) | ||
| # target_link_libraries(${PROJECT_NAME} PRIVATE Drogon::Drogon common llava | ||
| # ${CMAKE_THREAD_LIBS_INIT}) |
There was a problem hiding this comment.
what was replaced with in this section
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.