Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ulid generator is generating invalid value: 0001KPJAMH0000000000000000 #1822

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

namchuai
Copy link
Contributor

Describe Your Changes

  • ULID generate invalida data on windows

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

engine/utils/ulid_generator.h Outdated Show resolved Hide resolved
@namchuai namchuai force-pushed the hotfix/ulid-generator branch from 1eb5c79 to 5a12929 Compare December 23, 2024 10:35
@hiento09 hiento09 merged commit f56bf9b into main Dec 24, 2024
5 checks passed
@hiento09 hiento09 deleted the hotfix/ulid-generator branch December 24, 2024 02:04
namchuai added a commit that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants