Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rendering chat_template #1814

Merged
merged 1 commit into from
Dec 23, 2024
Merged

feat: rendering chat_template #1814

merged 1 commit into from
Dec 23, 2024

Conversation

namchuai
Copy link
Contributor

Describe Your Changes

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai force-pushed the j/apply-jinja-renderer branch 3 times, most recently from d187eca to 71f06d1 Compare December 20, 2024 07:35
@namchuai namchuai marked this pull request as ready for review December 20, 2024 07:37
@namchuai namchuai force-pushed the j/apply-jinja-renderer branch from 71f06d1 to 8a800f4 Compare December 20, 2024 08:10
@namchuai namchuai changed the title J/apply jinja renderer feat: rendering chat_template Dec 20, 2024
@namchuai namchuai force-pushed the j/apply-jinja-renderer branch 3 times, most recently from a8aa38d to 295e82e Compare December 22, 2024 17:14
engine/services/model_service.cc Outdated Show resolved Hide resolved
engine/utils/jinja_utils.h Show resolved Hide resolved
@namchuai namchuai force-pushed the j/apply-jinja-renderer branch from 295e82e to d01713f Compare December 23, 2024 04:01
@namchuai namchuai force-pushed the j/apply-jinja-renderer branch from d01713f to fdbe257 Compare December 23, 2024 04:03
@namchuai namchuai merged commit e408f78 into dev Dec 23, 2024
5 checks passed
@namchuai namchuai deleted the j/apply-jinja-renderer branch December 23, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants