adding libcurl to support pause/resume download #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namchuai
force-pushed
the
j/update-download-lib-to-curl
branch
8 times, most recently
from
ff8c324 to
df77be0
Compare
17 tasks
namchuai
force-pushed
the
j/update-download-lib-to-curl
branch
from
a7b2aa9 to
9848c32
Compare
namchuai
commented
Sep 12, 2024
namchuai
force-pushed
the
j/update-download-lib-to-curl
branch
6 times, most recently
from
6599960 to
c6a0e28
Compare
namchuai
changed the title
namchuai
force-pushed
the
j/update-download-lib-to-curl
branch
3 times, most recently
from
a7b3069 to
7c9550b
Compare
namchuai
requested review from
vansangpfiev,
nguyenhoangthuan99,
dan-homebrew and
louis-jan
namchuai
force-pushed
the
j/update-download-lib-to-curl
branch
from
7c9550b to
c3c3946
Compare
There was a problem hiding this comment.
@namchuai I will let @vansangpfiev and @nguyenhoangthuan99 review this, but left a couple of comments on naming and architecture.
| @@ -11,7 +10,7 @@ namespace commands { | |||
| #ifndef CORTEX_VARIANT | |||
| #define CORTEX_VARIANT file_manager_utils::kProdVariant | |||
| #endif | |||
| constexpr const auto kNightlyHost = "https://delta.jan.ai"; | |||
| constexpr const auto kNightlyHost = "delta.jan.ai"; | |||
There was a problem hiding this comment.
Should these be pulled out into a .cortexrc? It seems very fragile to hard code a lot of these? cc @vansangpfiev @nguyenhoangthuan99
There was a problem hiding this comment.
.cortexrc should be for things that are configurable for user? I doubt it's a suitable place.
And, IMO, we are not hard-coded here. We are defining compile time constants.
vansangpfiev
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
libcurl)Remaining things to do
cortex updateFixes Issues
Self Checklist