Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add variant support #1138

Merged
merged 1 commit into from
Sep 6, 2024
Merged

chore: add variant support #1138

merged 1 commit into from
Sep 6, 2024

Conversation

namchuai
Copy link
Contributor

@namchuai namchuai commented Sep 6, 2024 •
edited
Loading

Describe Your Changes

  • Adding support for 3 variants: prod, beta and nightly
  • Flag added to build command: -DCORTEX_VARIANT=beta

Screenshots

Test with beta env. To pull model
Expectation:

  • Configuration file created: Config file not found. Creating one at /Users/jamesnguyen/.cortexrc-beta
Screenshot 2024-09-06 at 15 32 10
  • Model downloaded at: ~/cortexcpp-beta
Screenshot 2024-09-06 at 15 33 41

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai force-pushed the chore/add-variant-support branch from 169ec83 to 9a9c132 Compare September 6, 2024 08:19
@namchuai namchuai force-pushed the chore/add-variant-support branch from 9a9c132 to d234a9d Compare September 6, 2024 08:22
@namchuai namchuai marked this pull request as ready for review September 6, 2024 08:23
@namchuai namchuai requested a review from hiento09 September 6, 2024 08:35
@namchuai namchuai merged commit a2e54ce into dev Sep 6, 2024
4 checks passed
@namchuai namchuai deleted the chore/add-variant-support branch September 6, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vansangpfiev vansangpfiev vansangpfiev approved these changes

@nguyenhoangthuan99 nguyenhoangthuan99 Awaiting requested review from nguyenhoangthuan99

@hiento09 hiento09 Awaiting requested review from hiento09

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namchuai @vansangpfiev