Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: guarantee lifetime for captured variables #1042

Merged
merged 3 commits into from
Aug 28, 2024
Merged

fix: guarantee lifetime for captured variables #1042

merged 3 commits into from
Aug 28, 2024

Conversation

vansangpfiev
Copy link
Contributor

@vansangpfiev vansangpfiev commented Aug 28, 2024 •
edited
Loading

  • Should capture by value for subcommand
  • Should capture by reference for option but guarantee the lifetime

@vansangpfiev vansangpfiev force-pushed the fix/pass-by-value-cli-cb branch from 8e36bfb to fe7c1fd Compare August 28, 2024 12:17
@vansangpfiev vansangpfiev changed the title fix: pass by value cli cb fix: guarantee lifetime for captured variables Aug 28, 2024
@vansangpfiev vansangpfiev merged commit bbc3e31 into feat/cortex-engine Aug 28, 2024
4 checks passed
@vansangpfiev vansangpfiev deleted the fix/pass-by-value-cli-cb branch August 28, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenhoangthuan99 nguyenhoangthuan99 nguyenhoangthuan99 approved these changes

@namchuai namchuai namchuai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vansangpfiev @namchuai @nguyenhoangthuan99