Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configurable Log path for main program and dependencies #1062

Closed
Tracked by #1153
nguyenhoangthuan99 opened this issue Aug 22, 2024 · 4 comments · Fixed by #1356
Closed
Tracked by #1153

feat: Configurable Log path for main program and dependencies #1062

nguyenhoangthuan99 opened this issue Aug 22, 2024 · 4 comments · Fixed by #1356
Assignees
Labels
category: app shell Installer, updaters, distributions P3: nice to have Nice to have feature
Milestone

Comments

@nguyenhoangthuan99
Copy link
Contributor

  • can set the log path of it's dependencies. E.g. cortex js & cpp. Whether or not to split should be configurable.
  • can toggle on/off its dependency's cache cleaning mechanism (to avoid side effects)

cc @marknguyen1302 for advice to make cortex.cpp work with Jan, thank you very much

@imtuyethan imtuyethan transferred this issue from another repository Sep 2, 2024
@freelerobot freelerobot changed the title Configurable Log path for main program and dependencies feat: Configurable Log path for main program and dependencies Sep 6, 2024
@freelerobot freelerobot added P3: nice to have Nice to have feature category: app shell Installer, updaters, distributions labels Sep 6, 2024
@dan-homebrew
Copy link
Contributor

Linked to #1153

@dan-homebrew
Copy link
Contributor

This is a great idea and should be part of .cortexrc

@dan-homebrew dan-homebrew moved this from Planning to Scheduled in Jan & Cortex Sep 29, 2024
@nguyenhoangthuan99 nguyenhoangthuan99 moved this from Scheduled to In Progress in Jan & Cortex Sep 30, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Review + QA in Jan & Cortex Sep 30, 2024
@nguyenhoangthuan99
Copy link
Contributor Author

nguyenhoangthuan99 commented Sep 30, 2024

PR #1356
This is the content of .cortexrc:

logFolderPath: /home/thuan/cortexcpp
logLlamaCppPath: ./logs/cortex.log
logTensorrtLLMPath: ./logs/cortex.log
logOnnxPath: ./logs/cortex.log
dataFolderPath: /home/thuan/cortexcpp
maxLogLines: 100000
apiServerHost: 127.0.0.1
apiServerPort: 3928
checkedForUpdateAt: 1727660326
latestRelease: v0.5.0

Now user can set the log location of each engine, the default location is the same with server cortex.log

@gabrielle-ong
Copy link
Contributor

gabrielle-ong commented Oct 3, 2024

Completed
Image

@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Jan & Cortex Oct 3, 2024
@gabrielle-ong gabrielle-ong added this to the v1.0.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: app shell Installer, updaters, distributions P3: nice to have Nice to have feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants